Relax some over-constrained impl bounds #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of these are removing `K: Hash + Eq` and/or `S: BuildHasher` where we don't actually need to hash anything. In some cases, we only get away with that because we have a saved hash in each entry `Bucket`. I *suspect* we still kept the constraints as API protection, in case we ever wanted to change our mind and stop saving the hash. However, there are a few other unconstrained methods that also need the saved hash, like `swap_remove_index` going back long before version 1.0 of the crate, so that ship has sailed.
Reference: commit 67a04b2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these are removing
K: Hash + Eqand/orS: BuildHasherwherewe don't actually need to hash anything.
In some cases, we only get away with that because we have a saved hash
in each entry
Bucket. I suspect we still kept the constraints as APIprotection, in case we ever wanted to change our mind and stop saving
the hash. However, there are a few other unconstrained methods that also
need the saved hash, like
swap_remove_indexgoing back long beforeversion 1.0 of the crate, so that ship has sailed.